Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when page moved , the setModified of type "PAGE_MOVED" has not excute #943

Closed
zhangzhenling opened this issue Sep 3, 2020 · 3 comments
Closed

when page moved , the setModified of type "PAGE_MOVED" has not excute #943

zhangzhenling opened this issue Sep 3, 2020 · 3 comments
Assignees
@andrewtelnov
Labels
bug
Milestone
v1.8.1

Comments

@zhangzhenling
Copy link

zhangzhenling commented Sep 3, 2020 •
edited
Loading

when page moved , the setModified of type "PAGE_MOVED" has not excute
@zhangzhenling
Copy link
Author

at page copy. setModified({ type: "PAGE_ADDED", newValue: newPage }) ,execute twice!

@andrewtelnov
Copy link
Member

@zhangzhenling I will take a look.

Thank you,
Andrew

@andrewtelnov andrewtelnov self-assigned this Sep 3, 2020
andrewtelnov added a commit that referenced this issue Sep 7, 2020
@andrewtelnov
Fix: when page moved , the setModified of type "PAGE_MOVED" has not e…
972ecfd 
…xcute #943
andrewtelnov added a commit that referenced this issue Sep 7, 2020
@andrewtelnov
Fix: Fire PAGE_ADDED one time on copying page, #943
445b224
@andrewtelnov
Copy link
Member

@zhangzhenling I have fixed these issues.

Thank you,
Andrew

@andrewtelnov andrewtelnov added this to the v1.8.1 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtelnov andrewtelnov

Labels
bug
Projects
None yet
Milestone
v1.8.1
Development

No branches or pull requests
2 participants
@andrewtelnov @zhangzhenling