Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose timestamps to the app #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mumoshu
Copy link

@mumoshu mumoshu commented Jun 19, 2023

These are the minimal changes that turned out to be necessary to the TiKV Rust client for our first implementation
of change feeds(might be renamed to CDC or whatever makes more sense- we don't have a roadmap item on our site yet!).

We will use these two functions for our unsound and sound variants of "change timestamps."
get_read_timestamp will be used for the unsound ones without making it "serializable."
get_current_timestamp will be used for the sound ones by wrapping it within the TiKV transactions to provide a virtual,
monotonic commit-timestamp-like timestamp.

We do know that neither of those is going to provide the ideal guarantee we might want for CDC, but we'll use it for
more performance-sensitive use cases and maybe as the baseline for benchmarking other implementations of "timestamps."

Hey @tobiemh, can we have a branch in our repo, named like 0.1.x or 0.1 that initially points to https://github.com/tikv/client-rust/tree/0.1.0, and merge this into the branch?

surrealdb currently relies on client-rust v0.1.0 and the master branch of this repo is very much ahead of v0.1.0.
I'd like to keep the changes minimal for now by separating introduction of these two functions from upgrading to a more recent version of client-rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant