Fix passing args to transforms

surgeventures · Sep 9, 2024 · 5fd6c7c · 5fd6c7c
1 parent b72d16b
commit 5fd6c7c
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 4 deletions.
diff --git a/lib/phase/apply_transforms.ex b/lib/phase/apply_transforms.ex
@@ -154,7 +154,7 @@ defmodule AbsintheHelpers.Phase.ApplyTransforms do
     transform_module =
       String.to_existing_atom("Elixir.AbsintheHelpers.Transforms.#{transform_camelized}Transform")
 
-    apply(transform_module, :call, [input | transform_args])
+    apply(transform_module, :call, [input, transform_args])
   end
 
   defp get_transforms(private) do

diff --git a/lib/transform.ex b/lib/transform.ex
@@ -3,5 +3,5 @@ defmodule AbsintheHelpers.Transform do
 
   alias Absinthe.Blueprint.Input
 
-  @callback call(Input.Value.t(), Keyword.t()) :: {:ok, Input.Value.t()} | {:error, atom()}
+  @callback call(Input.Value.t(), list()) :: {:ok, Input.Value.t()} | {:error, atom()}
 end
diff --git a/test/absinthe_helpers/phase/apply_transforms_test.exs b/test/absinthe_helpers/phase/apply_transforms_test.exs
@@ -32,6 +32,8 @@ defmodule AbsintheHelpers.Phase.ApplyTransformsTest do
         field(:override_ids, non_null(list_of(non_null(:id)))) do
           meta(transforms: [:trim, {:to_integer, true}])
         end
+
+        field(:accumulator, :string, meta: [transforms: [:to_integer, {:increment, 3}]])
       end
 
       def run_query(query) do
@@ -52,7 +54,8 @@ defmodule AbsintheHelpers.Phase.ApplyTransformsTest do
                    customer_id: 1,
                    service: %{
                      employee_id: 456,
-                     override_ids: [1, 2, 3]
+                     override_ids: [1, 2, 3],
+                     accumulator: 4
                    }
                  }
 
@@ -67,6 +70,7 @@ defmodule AbsintheHelpers.Phase.ApplyTransformsTest do
           service: {
             employee_id: "456",
             override_ids: ["1", "  2", "3"]
+            accumulator: "1"
           }
         )
       }
@@ -82,7 +86,8 @@ defmodule AbsintheHelpers.Phase.ApplyTransformsTest do
           customer_id: "1",
           service: {
             employee_id: "456",
-            override_ids: ["1", "invalid_id", "3"]
+            override_ids: ["1", "invalid_id", "3"],
+            accumulator: "1"
           }
         )
       }

diff --git a/test/support/transforms/increment_transform.ex b/test/support/transforms/increment_transform.ex
@@ -0,0 +1,9 @@
+defmodule AbsintheHelpers.Transforms.IncrementTransform do
+  alias Absinthe.Blueprint.Input
+
+  @behaviour AbsintheHelpers.Transform
+
+  def call(%Input.Value{data: data} = item, [step]) do
+    {:ok, %{item | data: data + step}}
+  end
+end