Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add template sample to test app #10

Merged
merged 1 commit into from
Apr 12, 2023
Merged

feat: add template sample to test app #10

merged 1 commit into from
Apr 12, 2023

Conversation

gsilvapt
Copy link
Contributor

As an example, because there is no theme configured here and this will have no impact in the app. However, another change to the project README is incoming after this change is merged to include a screenshot with an example of the template provided working with django-surface-theme.

@gsilvapt gsilvapt requested a review from a team as a code owner April 10, 2023 21:07
@gsilvapt gsilvapt requested review from cojoeu and bogdanoniga April 10, 2023 21:07
@gsilvapt gsilvapt mentioned this pull request Apr 10, 2023
fopina
fopina previously approved these changes Apr 10, 2023
@gsilvapt
Copy link
Contributor Author

In that case, perhaps we should close this one too, @fopina?

@fopina
Copy link

fopina commented Apr 11, 2023

I think this one makes sense.

for apitokens to be used/demoed in the testapp, it needs to be made available

@fopina fopina self-requested a review April 11, 2023 13:38
@fopina fopina dismissed their stale review April 11, 2023 13:38

testing

@fopina
Copy link

fopina commented Apr 11, 2023

I just noticed this is using navigation.html which does not exist in django-admin default template.

I meant that I think this makes perfect sense but applied to the core template 😄

@fopina
Copy link

fopina commented Apr 11, 2023

@fopina
Copy link

fopina commented Apr 11, 2023

pushed suggestion (navigation.html to be deleted).

image

Not the best look adding it after Log out but it was to avoid re-defining the entire block so it's easier to maintain. Options being before view site or after log out 🤷

@gsilvapt
Copy link
Contributor Author

LGTM, we can keep it like that 👍 testapp is merely for demonstration purposes, so I'm okay with this change. Thus I thought about adding the instructions to add the API Tokens part to the django-surface-theme instead of here - but again, I think it's a fine change anyway 👌

As an example, because there is no theme configured here and this will
have no impact in the app. **However**, another change to the project
`README` is incoming after this change is merged to include a screenshot
with an example of the template provided working with
`django-surface-theme`.
@fopina fopina merged commit c44be3a into develop Apr 12, 2023
@fopina fopina deleted the improve-docs branch April 12, 2023 05:39
gsilvapt added a commit that referenced this pull request Jul 27, 2023
* misc: properly call version attribute

* feat: add template sample to test app (#10)

As an example, because there is no theme configured here and this will
have no impact in the app. **However**, another change to the project
`README` is incoming after this change is merged to include a screenshot
with an example of the template provided working with
`django-surface-theme`.

* Update Django version in pyproject.toml (#12)

Signed-off-by: pacuraro <[email protected]>

* misc: version bump for new release

---------

Signed-off-by: pacuraro <[email protected]>
Co-authored-by: pacuraro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants