Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting idle queues doesn't work properly with FIFO #35

Closed
ryanwitt opened this issue Jul 6, 2018 · 1 comment
Closed

Deleting idle queues doesn't work properly with FIFO #35

ryanwitt opened this issue Jul 6, 2018 · 1 comment
Assignees
@ryanwitt
Labels
bug

Comments

@ryanwitt
Copy link
Member

ryanwitt commented Jul 6, 2018

When using idle-queues --delete, the normal behavior is to delete failed queues along with their normal counterpart.

SQS's naming scheme for FIFO queues (appending .fifo) messes this, up, because our normal _failed becomes _failed.fifo. This is handled properly in enqueue and worker but not in idle-queues.

The fix is to generate the failed queue names properly in the idle-queues command.
@ryanwitt ryanwitt added the bug label Jul 6, 2018
@ryanwitt ryanwitt self-assigned this Jul 6, 2018
ryanwitt added a commit that referenced this issue Jul 6, 2018
@ryanwitt
fix for #35, make idle queue pairing work properly for FIFO
758849b
@ryanwitt
Copy link
Member Author

ryanwitt commented Jul 7, 2018

fixed in 1.5.0

@ryanwitt ryanwitt closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanwitt ryanwitt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanwitt