Fix JUCE #3
Merged
Fix JUCE #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lang Co-authored-by: Pierre Guillot <[email protected]>
Before this change, when starting a mouse drag from a nested view such as a webview, JUCE was unable to automatically determine which component is associated with the drag. Instead of relying on automatic detection, users can pass the "sourceComponent" argument when initiating a drag to specify the parent view that should receive associated drag events. However, previously the sourceComponent was only used to find the view associated with the mouse-down, but not the mouse-up. Automatic detection was always used for the mouse-up, but this could fail in the case of a drag started from a nested view. Now, the drag event source will store a weak reference to the source component provided by the user, and use the same component for both mouse-down and mouse-up events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See juce-framework#1501