Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Interface and routing for email-password login #290

Merged
merged 5 commits into from
Feb 27, 2023

Conversation

iresharma
Copy link
Contributor

Summary of change

Email password login for dashboard recipe - Interfaces and routing logic added

Related issues

supertokens/dashboard#55

Test Plan

All existing tests pass

Documentation changes

None

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

Remaining TODOs for this PR

  • Interface and routing
  • API logic

@iresharma iresharma changed the base branch from master to feat/email-password-login February 27, 2023 07:20
@iresharma iresharma mentioned this pull request Feb 27, 2023
10 tasks
Base automatically changed from feat/email-password-login to email-password-feature-branch February 27, 2023 11:58
@nkshah2 nkshah2 merged commit 11a2feb into email-password-feature-branch Feb 27, 2023
@nkshah2 nkshah2 deleted the interface-changes branch February 27, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants