Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null props in access token #500

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Conversation

porcellus
Copy link
Collaborator

Summary of change

Fixes handling of nulls in access token payload

Related issues

Test Plan

  • Added a separate test in session token creation
  • Updated other tests that check if access token payload is kept consistent

Documentation changes

N/A, bugfix

Checklist for important updates

  • Changelog has been updated
    • If there are any db schema changes, mention those changes clearly
  • coreDriverInterfaceSupported.json file has been updated (if needed)
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

@rishabhpoddar rishabhpoddar merged commit 3ea4356 into 3.16 Sep 2, 2022
@rishabhpoddar rishabhpoddar deleted the fix/null_props_in_access_token branch September 2, 2022 05:26
@porcellus porcellus mentioned this pull request Sep 2, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants