-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Allow delivery to sharedInboxes where possible #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic for dereferencing, storing, and delivering to shared inboxes: https://www.w3.org/TR/activitypub/#shared-inbox-delivery
To do this, it adds a migration to add the field
shared_inbox_uri
to the gtsmodel.Account. This field is a string pointer, with three possible settings:Logic for looking up the shared inbox of an account has been added to the
GetRemoteAccount
function in the dereferencer. When that function is called, and we have a null value for SharedInboxURI, the account will be dereferenced (if it hasn't already) to discover the shared inbox address.This means that shared inboxes will gradually be discovered by your instance as you use it, rather than a bunch of calls happening all at once after updating, potentially breaking things.
If admins want to preserve the old delivery behavior, they can set the new config option
instance-deliver-to-shared-inboxes
to false :) Then, shared inboxes will still be discovered, they just won't be used. This defaults totrue
.