[bugfix] Use 'Image' instead of unrecognized 'Gif' type for media attachments #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this on goblin tech and it fixes the issue ^_^ Now gifs show as images normally in tusky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We made a mistake earlier with our implementation of the media attachment api: instead of storing gifs with type
Imagewe stored them with typeGif, which isn't part of the Mastodon API (Gifvis but that's for short looping soundless video files, not gifs). This meant that frontends like Tusky always showed gifs as unrecognized file types.This PR corrects this behavior by: