Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Change order of error checking after PostInbox #3394

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

tsmethurst
Copy link
Contributor

Check for malformed errors embedded inside error first, then check for gtserror.WithCode.

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request reorders error checking during PostInbox to check for any embedded malformed or actor missing errors first, then fall back to any gtserror.WithCode.

This accounts for cases where a malformed is embedded inside an 500 gtserror. In this case we care more about the embedded 400 as this is more informative for the caller.

closes #3168

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

Check for malformed errors embedded inside error *first*, then check for gtserror.WithCode.
@tsmethurst tsmethurst merged commit f037663 into main Oct 5, 2024
3 checks passed
@tsmethurst tsmethurst deleted the error_check_reorder branch October 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Sending a Follow Accept without an Actor results in 500
1 participant