[chore] update gruf / {go-cache, go-maps, go-kv} #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaaaWhatsUpDoc
commented
Sep 27, 2024
| @@ -54,15 +54,17 @@ func (m *ordered[K, V]) Delete(key K) bool { | |||
|
|
|||
| // Range passes given function over the requested range of the map. | |||
| func (m *ordered[K, V]) Range(start, length int, fn func(int, K, V)) { | |||
| // Nil check | |||
| if fn == nil { | |||
There was a problem hiding this comment.
it's a very simple fix (i wasn't correctly doing a nil check), but it should help in doing very large ranges on these ordered map types (used within our ttl caches, of which we still have a few), as the compiler should now know it doesn't need to do a nil check on every loop iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: https://codeberg.org/gruf/go-cache/releases/tag/v3.6.0
see: https://codeberg.org/gruf/go-maps/releases/tag/v1.0.4
see: https://codeberg.org/gruf/go-kv/releases/v1.6.5