Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix pending approval check #3316

Merged
merged 1 commit into from
Sep 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/federation/federatingdb/accept.go
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,8 @@ func (f *federatingDB) acceptStatusIRI(
return nil
}

if util.PtrOrValue(status.PendingApproval, false) {
pendingApproval := util.PtrOrValue(status.PendingApproval, false)
if !pendingApproval {
// Status doesn't need approval or it's
// already been approved by an Accept.
// Just return.
Expand Down Expand Up @@ -402,7 +403,8 @@ func (f *federatingDB) acceptLikeIRI(
return nil
}

if !util.PtrOrValue(fave.PendingApproval, false) {
pendingApproval := util.PtrOrValue(fave.PendingApproval, false)
if !pendingApproval {
// Like doesn't need approval or it's
// already been approved by an Accept.
// Just return.
Expand Down