-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[performance] cache more database calls, reduce required database calls overall #3290
Merged
NyaaaWhatsUpDoc
merged 31 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:performance/cache-fiddling
Sep 16, 2024
Merged
[performance] cache more database calls, reduce required database calls overall #3290
NyaaaWhatsUpDoc
merged 31 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:performance/cache-fiddling
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaaaWhatsUpDoc
force-pushed
the
performance/cache-fiddling
branch
from
September 12, 2024 17:35
2302396
to
c1a220e
Compare
NyaaaWhatsUpDoc
changed the title
[performance] cache more database calls, and reduce required database calls overall
[performance] cache more database calls, reduce required database calls overall
Sep 12, 2024
description now accurately described this PR, only thing that needs fixing is updating the list related tests :) |
tsmethurst
reviewed
Sep 14, 2024
tsmethurst
reviewed
Sep 14, 2024
tsmethurst
reviewed
Sep 14, 2024
tsmethurst
reviewed
Sep 14, 2024
tsmethurst
reviewed
Sep 14, 2024
tsmethurst
reviewed
Sep 14, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
tsmethurst
reviewed
Sep 16, 2024
…re now down by entry creation date)
…s at a time, fix up more tests
…ther small tweaks
NyaaaWhatsUpDoc
force-pushed
the
performance/cache-fiddling
branch
from
September 16, 2024 16:07
a1d4e12
to
6bd75b8
Compare
…r a RETURNING call)
…() instead of panic()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go-structr
to v0.8.9 which handles needing to check for an empty slice of uncached keysChecklist
go fmt ./...
andgolangci-lint run
.