Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Swagger: add missing filter_action param for v2 filter PUT #3281

Conversation

VyrCossont
Copy link
Contributor

@VyrCossont VyrCossont commented Sep 8, 2024

Description

This pull request adds Swagger docs for a parameter that should be present on PUT and POST for v2 filters, but was only on the docs for POST.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.
  • I/we have successfully generated code from the Swagger doc (for slurp, in this case)

@VyrCossont VyrCossont force-pushed the swagger-missing-filter_action-param-for-v2-filter-PUT branch from 4d74fa8 to 1100f17 Compare September 8, 2024 19:05
@tsmethurst tsmethurst merged commit 100d660 into superseriousbusiness:main Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants