Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] status dereferencing improvements #3255

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

  • in the case that mention only provides a namestring, search for existing mention by username,domain
  • handle definitely deleted statuses (i.e. they return 401) in the dereferencer by deleting them

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc force-pushed the chore/dereferencer-status-improvements branch from effde39 to 29827ec Compare September 9, 2024 11:26
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review September 9, 2024 11:26
@tsmethurst
Copy link
Contributor

Seems reasonable :) Just one small comment but not an important one, squerge away when you're happy.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 3254ef1 into superseriousbusiness:main Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants