Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security] Implement allowFiles fs for better isolation of ffmpeg / ffprobe #3251

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Aug 30, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request wraps access to files by ffmpeg and ffprobe in allowFiles, which implements fs.FS to allow only select permissions on in and out files.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc changed the title [chore] Implement readOneFile fs [security] Implement readOneFile fs for ffmpeg / ffprobe Aug 30, 2024
@tsmethurst tsmethurst changed the title [security] Implement readOneFile fs for ffmpeg / ffprobe [security] Implement allowFiles fs for better isolation of ffmpeg / ffprobe Aug 30, 2024
@tsmethurst tsmethurst merged commit cd93a5b into main Aug 30, 2024
3 checks passed
@tsmethurst tsmethurst deleted the wazero_hardening branch August 30, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant