[feature] Use local_only
field, deprecate federated
field
#3222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the status create API and status API model to use the
local_only
field to indicate non-federated statuses. Thelocal_only
field is already in use by implementations such as GlitchSoc, so this should make things a little easier for client app devs. To avoid breakage, thefederated
field has been deprecated. It still works, but only iflocal_only
is not set, andlocal_only
takes priority.Along the way, I also added checks for LocalOnly statuses to the visibility filter. We were already not serving unfederated statuses via the web frontend, but references to local-only posts were still being included in outboxes (not the posts themselves), and I think Public local-only posts were included in API responses if
instance-expose-public-timeline
was set to true. Not sure since I don't think anyone was actually using this combination of features.Closes #1035
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.