Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Use local_only field, deprecate federated field #3222

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request updates the status create API and status API model to use the local_only field to indicate non-federated statuses. The local_only field is already in use by implementations such as GlitchSoc, so this should make things a little easier for client app devs. To avoid breakage, the federated field has been deprecated. It still works, but only if local_only is not set, and local_only takes priority.

Along the way, I also added checks for LocalOnly statuses to the visibility filter. We were already not serving unfederated statuses via the web frontend, but references to local-only posts were still being included in outboxes (not the posts themselves), and I think Public local-only posts were included in API responses if instance-expose-public-timeline was set to true. Not sure since I don't think anyone was actually using this combination of features.

Closes #1035

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit 53fccb8 into main Aug 22, 2024
3 checks passed
@tsmethurst tsmethurst deleted the local_only_updates branch August 22, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] API does not expose whether a status is boostable / replyable / local-only
2 participants