[feature] Implement Mastodon-compatible roles #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Account.role` should only be available through verify_credentials for checking current user's permissions - `Account.role` now carries a Mastodon-compatible permissions bitmap and a marker for whether it should be shown to the public - `Account.roles` added for *public* display roles (undocumented but stable since Mastodon 4.1) - Web template now uses only public display roles (no user-visible change here, we already special-cased the `user` role)
VyrCossont
force-pushed
the
issue-3115-role-permission-bits
branch
from
42b2183 to
bca66da
Compare
|
a few comments but otherwise great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Account.roleshould only be available throughverify_credentialsfor checking current user's permissionsAccount.rolenow carries a Mastodon-compatible permissions bitmap and a marker for whether it should be shown to the publicAccount.rolesadded for public display roles (undocumented but stable since Mastodon 4.1)userrole)Closes #3115
Comments
We don't have or need Mastodon's elaborate custom permissions, but it costs us very little to be API-compatible with it in this case.
Implementing
Account.rolesis not strictly necessary for the feature request, but is closely adjacent and will make it easier for me to implement role badges in Feditext.Checklist
go fmt ./...andgolangci-lint run.