Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Explicitly propagate filter results from statuses to their boosts in API responses #3130

Conversation

VyrCossont
Copy link
Contributor

@VyrCossont VyrCossont commented Jul 22, 2024

Description

Explicitly propagate .Filtered from an original status to its boosts in the type converter, the same way we explicitly propagate ErrHideStatus.

This changes one line of actual code. The tests either ensure that existing filter-matching behavior continues (see #3128) or that .Filtered is copied.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@VyrCossont VyrCossont changed the title Explicitly propagate filter results from statuses to their boosts in API responses [bugfix] Explicitly propagate filter results from statuses to their boosts in API responses Jul 22, 2024
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 2d921d9 into superseriousbusiness:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants