[chore] Add interaction filter to complement existing visibility filter #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmethurst
changed the title
tsmethurst
force-pushed
the
interaction_filter
branch
from
90c2ea7 to
bc13816
Compare
tsmethurst
commented
Jul 17, 2024
|
|
||
| // TODO in next PR: check conditional / | ||
| // with approval and deref Accept. | ||
| if !replyable.Permitted() { |
There was a problem hiding this comment.
This (and the matching code in isPermittedBoost) looks a bit silly right now because it's basically a stub. In the next PR (which adds federation of interaction policies and Accepts), this will check if approvedByURI is set on the status, and go deref the Accept it references etc.
tsmethurst
commented
Jul 17, 2024
| pendingApproval = false | ||
| } | ||
|
|
||
| status.PendingApproval = &pendingApproval |
There was a problem hiding this comment.
This pending approval stuff will also be handled properly in the next PR, it doesn't do much now.
tsmethurst
force-pushed
the
interaction_filter
branch
from
2424e2f to
f48f9fe
Compare
tsmethurst
force-pushed
the
interaction_filter
branch
from
67da468 to
6a93e36
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is another intermediate PR and the next part of #3057.
It depends on #3108 to be squerged first.The PR adds a new "interaction filter" alongside the existing visibility filter. The interaction filter is used to check if a given interaction is permitted against a certain status.
In this PR only "permitted" and "forbidden" are used, but in the next PR (coming up after this one), "with approval" is also added.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]->[x]If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...andgolangci-lint run.