-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] media pipeline improvements #3110
[chore] media pipeline improvements #3110
Conversation
This seems pretty reasonable to me :) Can't say no to cheeky savings in the database. |
…ype from string to integer
… update attachment focus handling converting to frontend, update tests
179305d
to
b5eaf90
Compare
the tests were still failing as the new lazy initialization of the ffmpeg / ffprobe webassembly modules was causing the tests to timeout that were expecting some things to be processed within a certain timeframe. so i updated the lazy initialization to store just 1 open instance at testrig init, and all other instances it will initialize as it needs them :) |
Description
This updates our media processing to only store attachment path details on a successful store. This makes it easier to see attachments that are stored locally. It also tweaks the wording of the placeholder attachments warning such that it works for users that say don't want to store any local media whatsoever.
In the name of storage space / efficiency, the media attachments filetype column has also been updated from being a string, to be an integer that only gets stringified for the frontend. And the ffmpeg / ffprobe instance pools are updated such that instances are only allocated when they are needed now, so startup memory usage should be a bit lower. (though note that it will not "size back" after being allocated but during periods of low usage, that would end up adding significant complexity that's not worth it for server software).
Checklist
go fmt ./...
andgolangci-lint run
.