Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/frontend] Add player for audio files; use thumbnail for poster #3099

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Jul 13, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

In #3090 support was added for audio files, but no web frontend stuff was in place for it yet.

This PR:

  • adds audio support to the web frontend so that audio files can be played just like video files, using our existing player
  • adds a new status from zork to the testrig, in which he posts an audio file (the included audio file is Creative Commons licensed and is attributed in the media description).
  • updates some other frontend player stuff to use video poster instead of the video file itself as the video thumbnail. This should also improve page loading performance on pages with lots of videos
  • takes account of some Mastodon API eccentricities by providing framerate and original dimensions for audio files
  • collapses media gallery into single column when viewing on skinny screens, so the media controls don't become unusable

image

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

nice work! thanks for getting the frontend side of this working 😎

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 9efb11d into main Jul 15, 2024
3 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the audio_frontend branch July 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants