Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Allow gtsmodel to depend on util #3068

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[chore] Allow gtsmodel to depend on util #3068

merged 1 commit into from
Jul 3, 2024

Conversation

VyrCossont
Copy link
Contributor

Description

This pull request converts one free function into a gtsmodel.Emoji method so that util does not depend on gtsmodel and can be used from gtsmodel in the future.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@VyrCossont
Allow gtsmodel to depend on util
42f7cfa 
Convert one free function into a gtsmodel.Emoji method so that util does not depend on gtsmodel and can be used from it in the future
@tsmethurst
Copy link
Contributor

Looks good! Squerge if you're happy.

daenney
daenney approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@daenney daenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:. Having it on the emoji makes more sense to me.

@VyrCossont VyrCossont merged commit fde0c6b into superseriousbusiness:main Jul 3, 2024
2 checks passed
@VyrCossont VyrCossont deleted the allow-util-in-gtsmodel branch July 3, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daenney daenney daenney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VyrCossont @tsmethurst @daenney