Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update go-structr and go-mangler to no longer rely on modern-go/reflect2 #3026

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

Updates go-structr and go-mangler to no longer rely on modern-go/reflect2, which come release of Go 1.23 with changes to how linkname works (now requires both sides of a linkage to confirm it), means we will no longer be reliant on weird build tags to revert to old linkname behaviour.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

If you're happy then squerge :)

@NyaaaWhatsUpDoc
Copy link
Member Author

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit b93087c into superseriousbusiness:main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants