Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] filter API v2: restore keywords_attributes and statuses_attributes #2995

Merged
merged 1 commit into from
Jun 14, 2024
Merged

[feature] filter API v2: restore keywords_attributes and statuses_attributes #2995

merged 1 commit into from
Jun 14, 2024

Conversation

VyrCossont
Copy link
Contributor

Description

These filter API v2 features were cut late in development because the form encoding version is hard to implement correctly and because I thought no clients actually used keywords_attributes. Unfortunately, Phanpy does use keywords_attributes. Fortunately, it uses the JSON version.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@VyrCossont
Restore keywords_attributes and statuses_attributes
ae03321 
These filter API v2 features were cut late in development because the form encoding version is hard to implement correctly and because I thought no clients actually used `keywords_attributes`. Unfortunately, Phanpy does use `keywords_attributes`.
@tsmethurst tsmethurst merged commit b789fe2 into superseriousbusiness:main Jun 14, 2024
2 checks passed
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@VyrCossont @nyarla
[feature] filter API v2: Restore keywords_attributes and statuses_att…
e39e999 
…ributes (superseriousbusiness#2995)

These filter API v2 features were cut late in development because the form encoding version is hard to implement correctly and because I thought no clients actually used `keywords_attributes`. Unfortunately, Phanpy does use `keywords_attributes`.
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@VyrCossont @nyarla
[feature] filter API v2: Restore keywords_attributes and statuses_att…
b3c6ec0 
…ributes (superseriousbusiness#2995)

These filter API v2 features were cut late in development because the form encoding version is hard to implement correctly and because I thought no clients actually used `keywords_attributes`. Unfortunately, Phanpy does use `keywords_attributes`.
@VyrCossont VyrCossont deleted the resurrect-keywords_attributes branch July 26, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VyrCossont @tsmethurst