Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] paging rel links #2883

Merged
merged 4 commits into from
Apr 30, 2024
Merged

[bugfix] paging rel links #2883

merged 4 commits into from
Apr 30, 2024

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

Fix paging relative links so they use the correct cursoring parameter. Also updates the ASCII paging doc to explain this cursoring and make it clear.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Nice one, thanks for fixing :)

@tsmethurst tsmethurst merged commit 4f87ef2 into superseriousbusiness:main Apr 30, 2024
2 checks passed
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@NyaaaWhatsUpDoc @nyarla
[bugfix] paging rel links (superseriousbusiness#2883)
40c903c 
* fix paging so it uses correct cursor query parameter name

* improved code comment

* whoops, flip the cursoring 🤦

* fix the broken test
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
@NyaaaWhatsUpDoc @nyarla
[bugfix] paging rel links (superseriousbusiness#2883)
812345d 
* fix paging so it uses correct cursor query parameter name

* improved code comment

* whoops, flip the cursoring 🤦

* fix the broken test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NyaaaWhatsUpDoc @tsmethurst