Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/performance] Store account stats in separate table #2831

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Apr 14, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request changes the way we generate account stats. Previously, we were caching some stats in an in-memory cache. Before that, we just selected stats directly using COUNT queries every time an account needed to viewed via the API.

Instead in this PR stats are now stored in the database, and a best-effort is made to keep those stats up to date in the processing/worker functions.

This also means that we can now parse remote followers/following counts and store those, instead of having remote accounts always show counts only for local followers/following.

Stats for local accounts are regenerated if, when fetched from the cache/db, they haven't been regenerated for 24hrs or more, to avoid drift.

Some new functionality has been added to the cleaner package as well: every 24hrs at 1am a new "database cleaner" function will run. Currently this just regenerates stats for local accounts to prevent possible drift due to race conditions, but in future we could also use this new cleaner functionality to clean up old statuses when we get around to implementing that.

Should close #1887

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

NyaaaWhatsUpDoc commented Apr 14, 2024

a few comments, and i need to spend some more time thinking about the client locks just to make sure there isn't an issue, but otherwise looking good so far!

@tsmethurst tsmethurst force-pushed the account_stats_model branch from 5c54eea to dc065f7 Compare April 15, 2024 10:22
@tsmethurst tsmethurst marked this pull request as ready for review April 15, 2024 10:41
internal/federation/dereferencing/account.go Outdated Show resolved Hide resolved
internal/db/bundb/account.go Outdated Show resolved Hide resolved
@tsmethurst tsmethurst merged commit 3cceed1 into main Apr 16, 2024
3 checks passed
@tsmethurst tsmethurst deleted the account_stats_model branch April 16, 2024 11:10
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…iousbusiness#2831)

* [feature/performance] Store account stats in separate table, get stats from remote

* test account stats

* add some missing increment / decrement calls

* change stats function signatures

* rejig logging a bit

* use lock when updating stats
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…iousbusiness#2831)

* [feature/performance] Store account stats in separate table, get stats from remote

* test account stats

* add some missing increment / decrement calls

* change stats function signatures

* rejig logging a bit

* use lock when updating stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug/performance] Slow Postgres COUNT(*) queries
2 participants