-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/performance] Store account stats in separate table #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few comments, and i need to spend some more time thinking about the client locks just to make sure there isn't an issue, but otherwise looking good so far! |
tsmethurst
force-pushed
the
account_stats_model
branch
from
April 15, 2024 10:22
5c54eea
to
dc065f7
Compare
NyaaaWhatsUpDoc
requested changes
Apr 15, 2024
nyarla
pushed a commit
to nyarla/gotosocial-modded
that referenced
this pull request
Jun 19, 2024
…iousbusiness#2831) * [feature/performance] Store account stats in separate table, get stats from remote * test account stats * add some missing increment / decrement calls * change stats function signatures * rejig logging a bit * use lock when updating stats
nyarla
pushed a commit
to nyarla/gotosocial-modded
that referenced
this pull request
Jun 19, 2024
…iousbusiness#2831) * [feature/performance] Store account stats in separate table, get stats from remote * test account stats * add some missing increment / decrement calls * change stats function signatures * rejig logging a bit * use lock when updating stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the way we generate account stats. Previously, we were caching some stats in an in-memory cache. Before that, we just selected stats directly using COUNT queries every time an account needed to viewed via the API.
Instead in this PR stats are now stored in the database, and a best-effort is made to keep those stats up to date in the processing/worker functions.
This also means that we can now parse remote followers/following counts and store those, instead of having remote accounts always show counts only for local followers/following.
Stats for local accounts are regenerated if, when fetched from the cache/db, they haven't been regenerated for 24hrs or more, to avoid drift.
Some new functionality has been added to the cleaner package as well: every 24hrs at 1am a new "database cleaner" function will run. Currently this just regenerates stats for local accounts to prevent possible drift due to race conditions, but in future we could also use this new cleaner functionality to clean up old statuses when we get around to implementing that.Should close #1887
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.