Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Admin accounts endpoints; approve/reject sign-ups #2826

Merged
merged 18 commits into from
Apr 13, 2024

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request implements the rest of #703 by implementing functionality to allow admins to view pending account sign-ups, and approve or reject them.

  • implements /api/v1/admin/accounts and /api/v2/admin/accounts endpoints, to allow admins to page through lists of accounts with various parameters (follows Mastodon API).
  • implements /api/v1/admin/accounts/{id} endpoint, to allow admins to get the admin view of a specific account
  • implements new settings panel sections for browsing through accounts, and for showing a list of pending accounts
  • updates admin panel detailed account view with more stats about the account being viewed, and adds options to approve / reject sign-ups there
  • documents sign-up flow for admins
  • update various bits and bobs of the settings panel stuff, to use typescript a bit more

Closes #703

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst changed the title Admin signup settings [feature] Admin accounts endpoints; approve/reject sign-ups Apr 12, 2024
@NyaaaWhatsUpDoc
Copy link
Member

looking gooooooooood 🚀 👀

@tsmethurst tsmethurst merged commit 89e0cfd into main Apr 13, 2024
3 checks passed
@tsmethurst tsmethurst deleted the admin_signup_settings branch April 13, 2024 11:25
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…iousbusiness#2826)

* update settings panels, add pending overview + approve/deny functions

* add admin accounts get, approve, reject

* send approved/rejected emails

* use signup URL

* docs!

* email

* swagger

* web linting

* fix email tests

* wee lil fixerinos

* use new paging logic for GetAccounts() series of admin endpoints, small changes to query building

* shuffle useAccountIDIn check *before* adding to query

* fix parse from toot react error

* use `netip.Addr`

* put valid slices in globals

* optimistic updates for account state

---------

Co-authored-by: kim <[email protected]>
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…iousbusiness#2826)

* update settings panels, add pending overview + approve/deny functions

* add admin accounts get, approve, reject

* send approved/rejected emails

* use signup URL

* docs!

* email

* swagger

* web linting

* fix email tests

* wee lil fixerinos

* use new paging logic for GetAccounts() series of admin endpoints, small changes to query building

* shuffle useAccountIDIn check *before* adding to query

* fix parse from toot react error

* use `netip.Addr`

* put valid slices in globals

* optimistic updates for account state

---------

Co-authored-by: kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Account self-registration
2 participants