Weird notif issue #248
Merged
Weird notif issue #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where notifications were being streamed to a user for faves on statuses owned by other people.
The issue was caused by GtS assuming that any faves that arrived in an inbox should be faves of a status created by the inbox owner. However, other implementations like Misskey seem to federate faves by an account to all followers of that account, regardless of who actually posted the status.
The fix was to check who the fave was directed at before streaming a notification, rather than just assuming that the inbox owner and the status fave target owner are the same.