Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Don't copy ptr fields in caches #2386

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Nov 25, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This PR fixes the following scenario:

  • Some of my statuses get cached after database calls.
  • My account model is attached to those statuses.
  • I update my profile picture.
  • The statuses still show the old profile picture, on both the web view and via the API.

Essentially, what was happening in the above scenario is that the old account model was being kept on the cached statuses, and those statuses weren't being invalidated when the account model was updated.

There are two possible approaches to fixing this:

  1. Invalidate all cache entries that contain a pointer to a given account (or whatever) when that account (or whatever) updates; OR --
  2. Don't return cached struct pointers when copying a cached model and giving it to the caller.

This PR takes the second approach, on the basis that it will lead to fewer database calls than the first approach, and preclude super complicated cache invalidation logic.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

i think the issue you're likely seeing is probably in the timeline cache rather than the database cache, given that the timeline pre-prepares a frontend model with all the extra parts fully populated.

@tsmethurst tsmethurst marked this pull request as ready for review November 26, 2023 14:48
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 33ee615 into main Nov 27, 2023
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the cache_ptrs_fix branch November 27, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants