Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore/security] refactor AuthenticateFederatedRequest() to handle account deref + suspension checks #2371

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

Refactors our very crucial .AuthenticateFederatedRequest() function to handle new instance / account dereferencing, along with suspension checks. This reduces the need for these checks (and possibility of them being missed) in other areas of the codebase.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

tsmethurst commented Nov 20, 2023

Looks good to me, just a couple comments :)

@tsmethurst tsmethurst merged commit 42d8011 into superseriousbusiness:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants