Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Update poll delete/update db queries #2361

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request updates our db queries a little bit for polls:

  • Don't bother checking for db.ErrNoEntries on delete, since this is never returned; use RowsAffected instead. You can never recover from an error inside a transaction, so checking for an ErrNoEntries and continuing would cause the next query to fail anyways.
  • Fix choices slice return -- you can't do LIMIT on a Delete using bun, so bun doesn't know that only one row will be deleted, so you have to select into a slice of slices.
  • Select fewer columns where possible (v. small performance tweak).

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 0b99f14 into main Nov 14, 2023
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the poll_db_fixes branch November 14, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants