-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GetRemoteStatus and db.GetStatus() logic #174
Merged
tsmethurst
merged 18 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:bugfix/improve-getstatus-logic
Sep 1, 2021
Merged
Improve GetRemoteStatus and db.GetStatus() logic #174
tsmethurst
merged 18 commits into
superseriousbusiness:main
from
NyaaaWhatsUpDoc:bugfix/improve-getstatus-logic
Sep 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferencing Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
…odified status objects Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
Snuck in another bugfix with a panic caused by EnrichRemoteAccount :) |
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
NyaaaWhatsUpDoc
force-pushed
the
bugfix/improve-getstatus-logic
branch
from
August 30, 2021 20:40
ab1f141
to
64d422f
Compare
Signed-off-by: kim (grufwub) <[email protected]>
NyaaaWhatsUpDoc
force-pushed
the
bugfix/improve-getstatus-logic
branch
from
August 30, 2021 20:47
64d422f
to
e56d819
Compare
Signed-off-by: kim (grufwub) <[email protected]>
tsmethurst
requested changes
Aug 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the testing stuff needs to change, the rest looks great 👍
Signed-off-by: kim (grufwub) <[email protected]>
Signed-off-by: kim (grufwub) <[email protected]>
tsmethurst
reviewed
Sep 1, 2021
tsmethurst
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache=shared
by default on SQLite instances to ensure thread-safety between operations (this was the source of thenested transaction
related errors we were seeing). why this was not set as a default in a Go library where you have to go out of your way to run single-threaded?! who knows