Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frogend] Restructure form data default values / update from Query data #1422

Merged
merged 9 commits into from
Feb 6, 2023

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Feb 5, 2023

Description

Changes the way the form field hooks work so they take data from, and update as expected after queries.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@f0x52 f0x52 mentioned this pull request Feb 5, 2023
9 tasks
@tsmethurst
Copy link
Contributor

Nice one! looks good to me :)

@tsmethurst tsmethurst merged commit 47daddc into main Feb 6, 2023
@tsmethurst tsmethurst deleted the frogend-form-data branch February 6, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants