Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frogend] Filter local emoji #1385

Merged
merged 1 commit into from
Jan 27, 2023
Merged

[frogend] Filter local emoji #1385

merged 1 commit into from
Jan 27, 2023

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Jan 25, 2023

Description

image
image

Small quality-of-life improvement to the local emoji list, adding a bit of explanation and a text field to filter the list (similar to the federation domain list).

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@f0x52 f0x52 added the frontend Frontend-related stuff label Jan 25, 2023
@f0x52 f0x52 requested a review from tsmethurst January 25, 2023 13:35
@f0x52 f0x52 marked this pull request as draft January 25, 2023 13:36
@f0x52
Copy link
Contributor Author

f0x52 commented Jan 25, 2023

(Needs to be rebased after #1362 is merged, since it builds upon those CSS changes)

@f0x52 f0x52 force-pushed the filter-local-emoji branch from 226e67c to 9892d48 Compare January 25, 2023 17:10
@f0x52 f0x52 marked this pull request as ready for review January 25, 2023 17:14
@tsmethurst
Copy link
Contributor

lgtm! :)

@tsmethurst tsmethurst merged commit 08f8fea into main Jan 27, 2023
@tsmethurst tsmethurst deleted the filter-local-emoji branch January 27, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants