Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support Sec-Websocket-Protocol in streaming API #1254

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 12, 2022

Description

Implements Sec-Websocket-Protocol header for streaming.

closes #1248

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@matthewp matthewp marked this pull request as ready for review December 12, 2022 21:23
@NyaaaWhatsUpDoc
Copy link
Member

Have only taken a brief look but this looks really great :) I shall leave it up to @tsmethurst to perform a full review as I am quite limited in my time outside of work 😅

Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Couple of comments about a few small things related to tests + comments, but that's it :)

internal/api/client/streaming/streaming_test.go Outdated Show resolved Hide resolved
internal/api/client/streaming/streaming.go Outdated Show resolved Hide resolved
internal/api/client/streaming/streaming.go Outdated Show resolved Hide resolved
@matthewp
Copy link
Contributor Author

@tsmethurst Updated based on your review

@tsmethurst
Copy link
Contributor

great stuff, thank you!

@tsmethurst tsmethurst merged commit d10388c into superseriousbusiness:main Dec 14, 2022
@matthewp matthewp deleted the sec-websocket-protocol branch December 14, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] support access token passed as header
3 participants