[bugfix] fix unordered favorites

[voigt]

Description

This pull request fixes the ordering of favorites list.

closes #1151 (improves solution of #1236)

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

• I/we have read the GoToSocial contribution guidelines.
• I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
• I/we have performed a self-review of added code.
• I/we have written code that is legible and maintainable by others.
• I/we have commented the added code, particularly in hard-to-understand areas.
• I/we have made any necessary changes to documentation.
• I/we have added tests that cover new code.
• I/we have run tests and they pass locally with the changes.
• I/we have run go fmt ./... and golangci-lint run.

[voigt]

I'm still unsure whether to provide a test. What exactly would you like to be seen tested in this case?

[tsmethurst]

I'm still unsure whether to provide a test. What exactly would you like to be seen tested in this case?

Will respond to this later today, I've got some ideas :)

[voigt]

@tsmethurst Sure, let me know - happy to implement and improve testing! :)

[tsmethurst]

So I think a good way of more or less end-to-end testing this would be to just put some faves in the db, then retrieve them via the handler (so, a test in here somewhere: https://github.com/superseriousbusiness/gotosocial/tree/main/internal/api/client/favourites), and check that they're ordered correctly, and that the link headers are what we would expect. You can look around in some of the other api packages for some inspiration on testing, since we do something similar in a lot of places :) What do you think?

[voigt]

@tsmethurst I added a test, I hope this is what you expect. I added some test data, as you suggested, fetching the favorites of local_account_1 and checking whether the first and last items are correct.

[tsmethurst]

Great stuff, thank you! Can you add the license text header to the new files (just copy and paste from another .go file)? Then this is ready to be merged imo 👍

[voigt]

✅ Done!

[tsmethurst]

Thanks!