Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] allow uncaching of other media types #1234

Merged
merged 8 commits into from
Dec 12, 2022
Merged

[feature] allow uncaching of other media types #1234

merged 8 commits into from
Dec 12, 2022

Conversation

NyaaaWhatsUpDoc
Copy link
Member

No description provided.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as draft December 8, 2022 20:46
@NyaaaWhatsUpDoc
Copy link
Member Author

The failing test I'm pretty sure is due to me fiddling with the test models for remote media tests, something i'll take a look at another day

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc marked this pull request as ready for review December 9, 2022 18:29
tsmethurst
tsmethurst reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, nice! I'm pleasantly surprised by how few code changes this ended up requiring. So the refetch of avatars + headers Just Works now?

internal/media/prunemeta.go Show resolved Hide resolved
@NyaaaWhatsUpDoc
Copy link
Member Author

Huh, nice! I'm pleasantly surprised by how few code changes this ended up requiring. So the refetch of avatars + headers Just Works now?

it does! confirmed by the fact that before 899d385 i accidentally nuked all of my remote avatars/headers and they all reloaded :')

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc force-pushed the feature/allow-uncache-other-media branch from b88689f to ce4b4bb Compare December 9, 2022 20:16
@NyaaaWhatsUpDoc
Copy link
Member Author

@tsmethurst all tests are passing and this is ready to go now :)

turns out i inserted the generated preserialized key in the test account models area at the wrong index.

@tsmethurst
Copy link
Contributor

Sweet! Gonna try it out :D

@tsmethurst tsmethurst merged commit 58c87bd into superseriousbusiness:main Dec 12, 2022
@tsmethurst tsmethurst mentioned this pull request Dec 12, 2022
Closed
@trysdyn trysdyn mentioned this pull request Jan 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmethurst tsmethurst tsmethurst left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NyaaaWhatsUpDoc @tsmethurst