[chore] Remove duplicate prefixes from sanitizer #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous changes that expanded the IPv4 and IPv6 deny lists based on the IANA registries we inadvertently added a number of duplicates. This is unnecessary as they're already caught by larger prefixes and means there's less entries to scan. This change removes all prefixes that are subnets of other prefixes.
daenney
commented
Dec 1, 2022
| netip.MustParsePrefix("2001:3::/32"), // AMT, RFC 7450 | ||
| netip.MustParsePrefix("2001:4:112::/48"), // AS112-v6, RFC 7535 | ||
| netip.MustParsePrefix("2001:10::/28"), // ORCHID, deprecated | ||
| netip.MustParsePrefix("2001:20::/28"), // ORCHIDv2 |
There was a problem hiding this comment.
All the above 2001:.../xx prefixes are subnets of 2001::/23.
daenney
commented
Dec 1, 2022
| @@ -60,7 +52,6 @@ var ( | |||
| netip.MustParsePrefix("169.254.0.0/16"), // Link-local | |||
| netip.MustParsePrefix("172.16.0.0/12"), // Private | |||
| netip.MustParsePrefix("192.0.0.0/24"), // RFC6890 | |||
| netip.MustParsePrefix("192.0.0.0/29"), // IPv4 Service Continuity Prefix, RFC 7335 | |||
There was a problem hiding this comment.
This one is caught by 192.0.0.0/24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous changes that expanded the IPv4 and IPv6 deny lists based on the IANA registries we inadvertently added a number of duplicates. This is unnecessary as they're already caught by larger prefixes and means there's less entries to scan.
This change removes all prefixes that are subnets of other prefixes.
I solemnly swear this is the last of it.