[feature] add flac support (#3121)

* add flac support to the ffprobe format/stream -> filetype parser * also add audio/flac for flac (not just x-flac) * update tests --------- Co-authored-by: tobi <[email protected]>
superseriousbusiness · Jul 21, 2024 · c635080 · c635080
1 parent 027a93f
commit c635080
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/internal/api/client/instance/instancepatch_test.go b/internal/api/client/instance/instancepatch_test.go
@@ -109,6 +109,8 @@ func (suite *InstancePatchTestSuite) TestInstancePatch1() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",
@@ -243,6 +245,8 @@ func (suite *InstancePatchTestSuite) TestInstancePatch2() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",
@@ -377,6 +381,8 @@ func (suite *InstancePatchTestSuite) TestInstancePatch3() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",
@@ -562,6 +568,8 @@ func (suite *InstancePatchTestSuite) TestInstancePatch6() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",
@@ -718,6 +726,8 @@ func (suite *InstancePatchTestSuite) TestInstancePatch8() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",
@@ -893,6 +903,8 @@ func (suite *InstancePatchTestSuite) TestInstancePatch9() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",

diff --git a/internal/media/ffmpeg.go b/internal/media/ffmpeg.go
@@ -335,6 +335,8 @@ func (res *result) GetFileType() (gtsmodel.FileType, string) {
 		}
 	case "avi":
 		return gtsmodel.FileTypeVideo, "avi"
+	case "flac":
+		return gtsmodel.FileTypeAudio, "flac"
 	}
 	return gtsmodel.FileTypeUnknown, res.format
 }

diff --git a/internal/media/manager.go b/internal/media/manager.go
@@ -43,6 +43,9 @@ var SupportedMIMETypes = []string{
 
 	"video/x-msvideo", // .avi
 
+	"audio/flac",   // .flac
+	"audio/x-flac", // .flac
+
 	// png types
 	"image/png",  // .png
 	"image/apng", // .apng

diff --git a/internal/typeutils/internaltofrontend_test.go b/internal/typeutils/internaltofrontend_test.go
@@ -1432,6 +1432,8 @@ func (suite *InternalToFrontendTestSuite) TestInstanceV1ToFrontend() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",
@@ -1570,6 +1572,8 @@ func (suite *InternalToFrontendTestSuite) TestInstanceV2ToFrontend() {
         "audio/mp2",
         "audio/mp3",
         "video/x-msvideo",
+        "audio/flac",
+        "audio/x-flac",
         "image/png",
         "image/apng",
         "audio/ogg",