-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of flow parameters for ironing layer and previous layer #101
Conversation
Nice work Matt! |
should be mostly merged in 89b2e62 |
Does my version cover everything? It's in the last release. |
I will check it out! Thank you! |
Looks good to me so far. Generated gcode looks as it should. |
Sorry, I just got around to checking this out. The width parameter is great, works exactly as I'd hoped. |
great
I shouldn't, i code it to modify the % of plastic extruded in all fills that are "on top". In case of ironing, it's increasing the flow of the two steps.
The flow distribution between the two ironing steps? |
Yes sorry you're right. That is the current behavior. It was hard to tell because the ironing layer flow is set so low. I've spent a fair few hours testing which flow settings give the best results (including closely comparing to the output from cura, which gives great results in my experience) and from over 50 test specimens with a variety of different colours I've found that a flow of 1.1 for the top solid layer, and 0.1 for the ironing layer is great. But results may vary with different filament types. So for that reason, I think the two layers should be separated with adjustable flow parameters for each of them. OR, alternatively, can I propose we set the percentFlow[0] to 1.0 and percentFlow[1] to 0.1, and leave the top fill flow parameter as is. Then users can bump up the top fill flow parameter if needed (eg. to 1.1). What do you think? |
As a side note, can I also suggest that the width be set to 25% by default instead of 50%. This gives far better results with very minimal sacrifice of print time. |
Currently it's 80/20 (before is was 70/30)
will do |
Incredible results on that second ironing print, Matt. Just excellent! |
@Matts-Hub did you try to do 110/10 ironing on small features? |
For me 110/10 is 91.5/8.5 with 120% (top) flow
I removed the infill-perimeter overlap for the first step or ironing, and with the "Enforce 100% fill volume", small features shouldn't over-extrude more than the others. |
Oh right, then yes that makes sense. So that leaves us with two options I suppose. Either keep the top fill flow parameter as it is (and maybe find a way to set this to 120% when ironing is enabled?), and adjust percentFlow[0] to 0.9, and percentFlow[1] to 0.1. Or, make separate parameters for both, in which case the defaults should be something like 110/10. What do you think? |
I created the top flow because it can be useful for other top pattern. So I prefer option1. For the "only when ironing is enabled", you can say the same for many many other parameters... But if i do that, it will confuse users. Best way is to let users created their "conditional parameters switches" or things like that with a small macro language, but it's low in my priority list. |
Ok great. I think that's a good solution then!
I think you're right, that might unnecessarily complicate things. |
last version should be okay |
Add in ironing flow adjustment parameters