Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase recursion depth limit to 50 #468

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

supermacro
Copy link
Owner

@supermacro supermacro commented Apr 17, 2023

work-in-progress fix for #441

This PR increases the iteration count to 50 - meaning now neverthrow would be able to have inference of tuples containing up to 49 elements.

Note that TypeScript itself has a recursion depth limit set to 50 (as per this issue so I respect this limit even though it looks like recently that limit has been increased to 100).

Todo:

  • Ensure this fix works for Result.combine
  • Ensure this fix works for Result.combineWithAllErrors
  • Ensure this fix works for ResultAsync.combine
  • Ensure this fix works for ResultAsync.combineWithAllErrors

@supermacro supermacro changed the title Implement fix for Result.combine Increase recursion depth limit to 50 Apr 17, 2023
@supermacro supermacro marked this pull request as ready for review April 18, 2023 01:55
@supermacro supermacro merged commit f72e08c into master Apr 18, 2023
@supermacro supermacro deleted the increase-recursion-depth-limit branch April 18, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant