-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulation of Rust's ? operator #448
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
060d1e9
Emulation of Rust's ? operator
tsuburin 19eed44
Remove unintended empty line
tsuburin 33452a7
Fix error message
tsuburin b09ce2f
Merge branch 'master' into master
tsuburin 30b65f5
Merge branch 'master' into master
tsuburin 0cfab20
Merge branch 'master' into master
tsuburin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
export { Result, ok, Ok, err, Err, fromThrowable } from './result' | ||
export { Result, ok, Ok, err, Err, fromThrowable, safeTry } from './result' | ||
export { ResultAsync, okAsync, errAsync, fromPromise, fromSafePromise } from './result-async' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
import { | ||
safeTry, | ||
ok, | ||
okAsync, | ||
err, | ||
errAsync, | ||
Ok, | ||
Err | ||
} from "../src" | ||
|
||
describe('Returns what is returned from the generator function', () => { | ||
const val = "value" | ||
|
||
test("With synchronous Ok", () => { | ||
const res = safeTry(function*() { | ||
return ok(val) | ||
}) | ||
expect(res).toBeInstanceOf(Ok) | ||
expect(res._unsafeUnwrap()).toBe(val) | ||
}) | ||
|
||
test("With synchronous Err", () => { | ||
const res = safeTry(function*() { | ||
return err(val) | ||
}) | ||
expect(res).toBeInstanceOf(Err) | ||
expect(res._unsafeUnwrapErr()).toBe(val) | ||
}) | ||
|
||
test("With async Ok", async () => { | ||
const res = await safeTry(async function*() { | ||
return await okAsync(val) | ||
}) | ||
expect(res).toBeInstanceOf(Ok) | ||
expect(res._unsafeUnwrap()).toBe(val) | ||
}) | ||
|
||
test("With async Err", async () => { | ||
const res = await safeTry(async function*() { | ||
return await errAsync(val) | ||
}) | ||
expect(res).toBeInstanceOf(Err) | ||
expect(res._unsafeUnwrapErr()).toBe(val) | ||
}) | ||
}) | ||
|
||
describe("Returns the first occurence of Err instance as yiled*'s operand", () => { | ||
test("With synchronous results", () => { | ||
const errVal = "err" | ||
const okValues = Array<string>() | ||
|
||
const result = safeTry(function*() { | ||
const okFoo = yield* ok("foo").safeUnwrap() | ||
okValues.push(okFoo) | ||
|
||
const okBar = yield* ok("bar").safeUnwrap() | ||
okValues.push(okBar) | ||
|
||
yield* err(errVal).safeUnwrap() | ||
|
||
throw new Error("This line should not be executed") | ||
}) | ||
|
||
expect(okValues).toMatchObject(["foo", "bar"]) | ||
|
||
expect(result).toBeInstanceOf(Err) | ||
expect(result._unsafeUnwrapErr()).toBe(errVal) | ||
}) | ||
|
||
test("With async results", async () => { | ||
const errVal = "err" | ||
const okValues = Array<string>() | ||
|
||
const result = await safeTry(async function*() { | ||
const okFoo = yield* okAsync("foo").safeUnwrap() | ||
okValues.push(okFoo) | ||
|
||
const okBar = yield* okAsync("bar").safeUnwrap() | ||
okValues.push(okBar) | ||
|
||
yield* errAsync(errVal).safeUnwrap() | ||
|
||
throw new Error("This line should not be executed") | ||
}) | ||
|
||
expect(okValues).toMatchObject(["foo", "bar"]) | ||
|
||
expect(result).toBeInstanceOf(Err) | ||
expect(result._unsafeUnwrapErr()).toBe(errVal) | ||
}) | ||
|
||
test("Mix results of synchronous and async in AsyncGenerator", async () => { | ||
const errVal = "err" | ||
const okValues = Array<string>() | ||
|
||
const result = await safeTry(async function*() { | ||
const okFoo = yield* okAsync("foo").safeUnwrap() | ||
okValues.push(okFoo) | ||
|
||
const okBar = yield* ok("bar").safeUnwrap() | ||
okValues.push(okBar) | ||
|
||
yield* err(errVal).safeUnwrap() | ||
|
||
throw new Error("This line should not be executed") | ||
}) | ||
|
||
expect(okValues).toMatchObject(["foo", "bar"]) | ||
|
||
expect(result).toBeInstanceOf(Err) | ||
expect(result._unsafeUnwrapErr()).toBe(errVal) | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically I can do something like