fix: flyctl deploy flag from region to regions #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-j
approved these changes
May 4, 2024
|
ETA on getting merged in? |
|
@bryantbrock how do we manage the situation till this PR is merged? Can we use the edits your made in the steps? |
Yes you can, that's what I'm doing (thanks @bryantbrock) In your workflow, you can update the uses: bryantbrock/fly-pr-review-apps@6e34c6a6405b85220fb22ee564d32ce89c3dc384✨ |
dennisrb2
added a commit
to rb2-bv/fly-pr-review-apps
that referenced
this pull request
May 6, 2024
fix: flyctl deploy flag from region to regions (superfly#56)
lbrito1
added a commit
to lbrito1/fly-pr-review-apps
that referenced
this pull request
May 6, 2024
lbrito1
added a commit
to lbrito1/fly-pr-review-apps
that referenced
this pull request
May 6, 2024
|
Thanks for the merge. I'm trying to push preview app but fails with the same error. There is no version change. So what am I missing? Thank you @bryantbrock for the patch. |
|
@ragbadaskar you should see a new release now, v1.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyctlv0.2.47 [PR] silently broke everyones CI/CDs. It broke my review apps. This fixes that change.This really needs to go out ASAP as it breaks ALL review apps until it's fixed. I'm changing mine to manually run this code until this is merged in and released.