Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional detached deployment option #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add optional detached deployment option #53

wants to merge 1 commit into from

Conversation

som-matrix
Copy link

  • This PR introduces the ability to control the deployment behavior of the Fly app within our GitHub Actions workflow. Users can now specify whether the deployment should run in a detached mode, which allows the GitHub Actions runner to proceed without waiting for the deployment to complete. This feature is particularly useful for workflows where immediate feedback from the deployment process is not necessary, helping to reduce wait times and potential bottlenecks in continuous integration pipelines.

Changes

  • Added a new environment variable INPUT_WAIT, which users can set to true if they wish for the deployment to wait until completion. By default, the deployment runs in detached mode.
  • Modified the flyctl deploy command to accept a --detach flag based on the INPUT_WAIT setting, enabling either immediate return or waiting for the deployment process.

@som-matrix som-matrix changed the title Add Optional Detached Deployment for Fly App in GitHub ActionsAdd detach option Add optional detached deployment option Apr 29, 2024
@som-matrix
Copy link
Author

Hi folks , please review this when you are free

@som-matrix som-matrix force-pushed the add-detach-option branch 2 times, most recently from 293ab9c to 5aa2763 Compare May 21, 2024 11:13
@som-matrix som-matrix force-pushed the add-detach-option branch from 5aa2763 to 078f2b2 Compare May 21, 2024 11:33
@som-matrix
Copy link
Author

Hi folks gentle reminder , please review this when you are free

@som-matrix
Copy link
Author

gentle reminder folks, please review this when you are free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@som-matrix