Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get remote builder with organization #65

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Get remote builder with organization #65

merged 4 commits into from
Jun 7, 2024

Conversation

billyb2
Copy link
Contributor

@billyb2 billyb2 commented May 31, 2024

No description provided.

@billyb2 billyb2 force-pushed the set_remote_builder branch from 3f7cf7f to 69338ef Compare June 4, 2024 18:56
@billyb2 billyb2 changed the title Add SetRemoteBuilder mutation Get remote builder with organization Jun 4, 2024
@billyb2 billyb2 marked this pull request as ready for review June 4, 2024 18:57
@benbjohnson
Copy link
Collaborator

@billyb2 This seems like a lot of extra info to pull for every GetApp(). I'm not sure what the performance implications would be for that. It might be better to have an explicit GetRemoteBuilderApp() call.

@billyb2
Copy link
Contributor Author

billyb2 commented Jun 6, 2024

@billyb2 This seems like a lot of extra info to pull for every GetApp(). I'm not sure what the performance implications would be for that. It might be better to have an explicit GetRemoteBuilderApp() call.

sounds good!

@billyb2 billyb2 force-pushed the set_remote_builder branch from 11760de to 5cace8d Compare June 7, 2024 16:22
@billyb2 billyb2 requested a review from benbjohnson June 7, 2024 16:23
@billyb2 billyb2 merged commit 6d967cc into main Jun 7, 2024
5 checks passed
@billyb2 billyb2 deleted the set_remote_builder branch June 7, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants