[ETHEREUM-CONTRACTS] fix simple forwarder (alternative solution) #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
d10r
changed the title
hellwolf
approved these changes
Dec 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2045 +/- ##
=======================================
Coverage 88.15% 88.15%
=======================================
Files 109 109
Lines 6862 6862
Branches 987 985 -2
=======================================
Hits 6049 6049
Misses 811 811
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
XKCD Comic RelifLink: https://xkcd.com/2045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2044 fixes the issue by removing the
onlyOwnerclause from SimpleForwarder.This PR fixes it by giving up on the idea of having the contract deployed in the constructor of Superfluid, allowing the SimpleForwarder contract to remain unchanged, at the price of adding another constructor argument to Superfluid.