Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[METADATA] added macroForwarder, updated batchLiquidator #2015

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Aug 30, 2024

MacroForwarder: related to https://github.com/superfluid-finance/superfluid-stories/issues/712, #2014

BatchLiquidator: was changed PR1357. Since it was a breaking change without proper versioning, and not being able to do an atomic rollout across the stack, we didn't immediately update metadata to the new contracts. Now we're ready for that, which also allows us to remove workarounds in sentinel and graphinator once this is released.

Copy link

github-actions bot commented Aug 30, 2024

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r d10r changed the title [metadata] added macroForwarder, updated batchLiquidator [METADATA] added macroForwarder, updated batchLiquidator Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (9a4abaf) to head (c123b00).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2015   +/-   ##
=======================================
  Coverage   88.36%   88.36%           
=======================================
  Files         111      111           
  Lines        6999     6999           
  Branches      961      961           
=======================================
  Hits         6185     6185           
  Misses        812      812           
  Partials        2        2           
Flag Coverage Δ
ethereum-contracts 94.51% <ø> (ø)
sdk-core 88.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d10r d10r merged commit fb6cd05 into dev Aug 30, 2024
26 checks passed
@d10r d10r deleted the metadata_1.5.0 branch August 30, 2024 11:16
Copy link

XKCD Comic Relif

Link: https://xkcd.com/2015
https://xkcd.com/2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants