-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small build pipeline improvements #2005
Conversation
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what motivates the change, hope it's worth it.
didi@P1G4:~/src/sf/protocol-monorepo$ time jq --version
jq-1.7.1
real 0m0.002s
user 0m0.001s
sys 0m0.000s
didi@P1G4:~/src/sf/protocol-monorepo$ time npx --no --package=node-jq -- jq --version
jq-1.7.1
real 0m2.892s
user 0m3.890s
sys 0m1.226s
The origin of having to add this $JQ is because ubuntu docker provided by github at some point removed jq from the pre-installs, and at that time the build system has not been utilizing nix yet. The npx performance seems unnecessarily poor, indeed, though it's not the primary goal of the build system; the primary goal should still be reproducibility. However, since we now already use nix, I might as well revert back and use |
XKCD Comic RelifLink: https://xkcd.com/2005 |
No description provided.