Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small build pipeline improvements #2005

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

hellwolf
Copy link
Contributor

No description provided.

@hellwolf hellwolf marked this pull request as ready for review August 19, 2024 13:39
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r
Copy link
Collaborator

d10r commented Aug 19, 2024

please don't yet merge, I want to add something
nvm

Copy link
Collaborator

@d10r d10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what motivates the change, hope it's worth it.

didi@P1G4:~/src/sf/protocol-monorepo$ time jq --version
jq-1.7.1

real    0m0.002s
user    0m0.001s
sys     0m0.000s
didi@P1G4:~/src/sf/protocol-monorepo$ time npx --no --package=node-jq -- jq --version
jq-1.7.1

real    0m2.892s
user    0m3.890s
sys     0m1.226s

@hellwolf
Copy link
Contributor Author

I don't know what motivates the change, hope it's worth it.

The origin of having to add this $JQ is because ubuntu docker provided by github at some point removed jq from the pre-installs, and at that time the build system has not been utilizing nix yet.

The npx performance seems unnecessarily poor, indeed, though it's not the primary goal of the build system; the primary goal should still be reproducibility.

However, since we now already use nix, I might as well revert back and use jq directly assuming either it's run in nixified build system or locally that you have jq installed (nix or non-nix way).

@hellwolf hellwolf enabled auto-merge August 21, 2024 09:31
@hellwolf hellwolf added this pull request to the merge queue Aug 21, 2024
Merged via the queue into dev with commit 23b300d Aug 21, 2024
18 checks passed
@hellwolf hellwolf deleted the small-build-pipeline-improvements branch August 21, 2024 11:21
Copy link

XKCD Comic Relif

Link: https://xkcd.com/2005
https://xkcd.com/2005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants